Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11493 +/- ##
==========================================
+ Coverage 82.56% 82.61% +0.05%
==========================================
Files 938 938
Lines 248247 248311 +64
==========================================
+ Hits 204961 205153 +192
+ Misses 43286 43158 -128
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 21537 |
victorjulien
approved these changes
Jul 17, 2024
Merged
Member
|
Merged in #11515, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/1125
https://redmine.openinfosecfoundation.org/issues/6821
https://redmine.openinfosecfoundation.org/issues/5491
Describe changes:
SV_BRANCH=OISF/suricata-verify#1894
#11333 just rebased after QA analysis
It is good to have less ftp txs that should be really IRC txs/flows...
This PR does not add IRC detection, but brings improvements nevertheless